[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] tcg: Add debug facilities for TCGv
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] tcg: Add debug facilities for TCGv |
Date: |
Sat, 10 Dec 2011 10:07:03 +0000 |
On 10 December 2011 09:02, Andreas Färber <address@hidden> wrote:
> Working on 16- and 20-bit targets using TARGET_LONG_BITS == 32, I found it too
> easy to accidentally use, e.g., tcg_temp_free() in place of
> tcg_temp_free_i32().
> In case of 78k0/rl78 it may not practically matter yet, but it complicates
> going from a 32-bit target to 64 bits, as in the case of arm.
>
> This series refactors TCG code to allow using a dedicated struct for TCGv,
> to make variable type mismatches show up as compilation errors.
What mismatches does this catch that the existing debug code doesn't?
I've always assumed that "TCGv is shorthand for either TCGv_32 or TCGv_64
depending on your target's word length" was a feature, not a bug.
If we don't like that we should just drop TCGv completely, no?
-- PMM
- [Qemu-devel] [PATCH 0/4] tcg: Add debug facilities for TCGv, Andreas Färber, 2011/12/10
- [Qemu-devel] [PATCH 3/4] tcg: Update TCGV_{UNUSED,EQUAL}() macros, Andreas Färber, 2011/12/10
- [Qemu-devel] [PATCH 1/4] tcg: Introduce {MAKE,GET}_TCGV_TL macros, Andreas Färber, 2011/12/10
- [Qemu-devel] [PATCH 4/4] tcg: Allow to detect TCGv misuses, Andreas Färber, 2011/12/10
- [Qemu-devel] [PATCH 2/4] tcg: Convert *_tl*() macros to inline functions, Andreas Färber, 2011/12/10
- Re: [Qemu-devel] [PATCH 0/4] tcg: Add debug facilities for TCGv,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 0/4] tcg: Add debug facilities for TCGv, Andreas Färber, 2011/12/10
- Re: [Qemu-devel] [PATCH 0/4] tcg: Add debug facilities for TCGv, Paul Brook, 2011/12/11
- Re: [Qemu-devel] [PATCH 0/4] tcg: Add debug facilities for TCGv, Andreas Färber, 2011/12/12
- Re: [Qemu-devel] [PATCH 0/4] tcg: Add debug facilities for TCGv, Paul Brook, 2011/12/12
- Re: [Qemu-devel] [PATCH 0/4] tcg: Add debug facilities for TCGv, Andreas Färber, 2011/12/13
- Re: [Qemu-devel] [PATCH 0/4] tcg: Add debug facilities for TCGv, Paul Brook, 2011/12/13
- Re: [Qemu-devel] [PATCH 0/4] tcg: Add debug facilities for TCGv, Andreas Färber, 2011/12/14
- Re: [Qemu-devel] [PATCH 0/4] tcg: Add debug facilities for TCGv, Andreas Färber, 2011/12/13
- Re: [Qemu-devel] [PATCH 0/4] tcg: Add debug facilities for TCGv, Paul Brook, 2011/12/13