[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix parse of usb device description with multip
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH] Fix parse of usb device description with multiple configurations |
|
Date: |
Mon, 12 Dec 2011 09:23:28 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111104 Red Hat/3.1.16-2.el6_1 Thunderbird/3.1.16 |
Hi,
> + } else if (descriptors[i + 5] != s->configuration) {
> + fprintf(stderr, "not requested configuration %d\n",
> + s->configuration);
> + i += (descriptors[i + 3] << 8) + descriptors[i + 2];
> + continue;
> + }
That message doesn't indicate an error and should be a DPRINTF instead
of a fprintf. Otherwise the patch looks fine.
cheers,
Gerd