[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 01/17] block: do not rely on open_flags for bdrv_is_
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 01/17] block: do not rely on open_flags for bdrv_is_snapshot |
Date: |
Tue, 13 Dec 2011 13:37:04 +0100 |
The BDRV_O_SNAPSHOT flag is stored in open_flags but not passed to
bdrv_open. This makes the usage of bs->open_flags wrong in
bdrv_snapshot_goto.
(Instead, bdrv_commit uses the backing file's open_flags and those
flags never include any of BDRV_O_SNAPSHOT, BDRV_O_NO_BACKING
or BDRV_O_RDWR).
We will fix the open_flags soon. In the meanwhile, do not rely
on open_flags including BDRV_O_SNAPSHOT.
Signed-off-by: Paolo Bonzini <address@hidden>
---
block.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block.c b/block.c
index 56c7981..a96f080 100644
--- a/block.c
+++ b/block.c
@@ -2463,7 +2463,7 @@ int bdrv_can_snapshot(BlockDriverState *bs)
int bdrv_is_snapshot(BlockDriverState *bs)
{
- return !!(bs->open_flags & BDRV_O_SNAPSHOT);
+ return bs->is_temporary;
}
BlockDriverState *bdrv_snapshots(void)
--
1.7.7.1
- [Qemu-devel] [PATCH 00/17] Support mismatched host and guest logical block sizes, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 01/17] block: do not rely on open_flags for bdrv_is_snapshot,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 02/17] block: store actual flags in bs->open_flags, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 05/17] block: remove enable_write_cache, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 03/17] block: pass protocol flags up to the format, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 04/17] block: non-raw protocols never cache, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 06/17] block: move flag bits together, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 07/17] raw: remove the aligned_buf, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 08/17] block: rename buffer_alignment to guest_block_size, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 09/17] block: add host_block_size, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 11/17] iscsi: save host block size, Paolo Bonzini, 2011/12/13