Re: [Qemu-devel] [PATCH 2/2] device_isolation: Support isolation on POWER p7ioc (IODA) bridges

[Michael Ellerman]

On Thu, 2011-12-15 at 17:08 +1100, David Gibson wrote:
> This patch adds code to the code for the powernv platform to create
> and populate isolation groups on hardware using the p7ioc (aka IODA) PCI host
> bridge used on some IBM POWER systems.

> diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c 
> b/arch/powerpc/platforms/powernv/pci-ioda.c
> index 0cdc8302..6df632e 100644
> --- a/arch/powerpc/platforms/powernv/pci-ioda.c
> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> @@ -861,6 +862,9 @@ static void __devinit pnv_ioda_setup_bus_dma(struct 
> pnv_ioda_pe *pe,
>               set_iommu_table_base(&dev->dev, &pe->tce32_table);
>               if (dev->subordinate)
>                       pnv_ioda_setup_bus_dma(pe, dev->subordinate);
> +#ifdef CONFIG_DEVICE_ISOLATION
> +             device_isolation_dev_add(&pe->di_group, &dev->dev);
> +#endif

You already have a nop version of that in device_isolation.h, so the
ifdef is not required AFAICS.

And similarly elsewhere.

cheers

signature.asc
Description: This is a digitally signed message part