[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] [RFC] Remove ppc_newworld/ppc_oldworld
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH] [RFC] Remove ppc_newworld/ppc_oldworld |
Date: |
Fri, 16 Dec 2011 21:06:53 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111105 Thunderbird/8.0 |
Am 16.12.2011 19:08, schrieb Anthony Liguori:
> I notice that these two machines have seem to have never really been touched
> other than tree-wide refactoring since their introduction. Googling for the
> machine types doesn't hit any user questions or comments about the machine
> types.
>
> For the most part, the devices haven't been converted to qdev and are actually
> the only remaining PCI devices that haven't been.
>
> To me this indicates that the code currently isn't being used by anyone. I
> can do the qdev conversions if it is, but as far as I can tell, it's just bit
> rotting right now.
>
> Is this accurate? Can we remove this code? If there is future interest here,
> it's easy enough to revert this, fix up the code, and resubmit.
No. There's an easy explanation why you might not find much mentions of
the machine names: g3beige (ppc_oldworld.c) is the default for
qemu-system-ppc, and mac99 (ppc_newworld.c) is the default for
qemu-system-ppc64.
If there's something ppc you'd like to remove then I would be open about
discussing the current ppc_prep.c machine but not its infrastructure
(prep_pci etc. - there we started a qdev'ification) as that's needed for
40p and bebox machines. I was holding back any refactorings while
MemoryRegion API was a moving target and now QOM didn't seem inviting
either. ;)
Andreas