|
| From: | Avi Kivity |
| Subject: | Re: [Qemu-devel] [PATCH 2/3] hw/sd.c: add SD card save/load support |
| Date: | Tue, 27 Dec 2011 16:13:46 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 |
On 12/26/2011 04:58 PM, Peter Maydell wrote:
> >
> > void sd_enable(SDState *sd, int enable)
> > {
> > - sd->enable = enable;
> > + sd->enable = enable ? true : false;
>
> This kind of thing is why I don't like bool :-)
/me leaps to bool's defence:
sd->enable = enable should work just fine. The assignment is
equivalent to sd->enable = enable != 0, as conversion to bool coerces
the value to true/false.
--
error compiling committee.c: too many arguments to function
| [Prev in Thread] | Current Thread | [Next in Thread] |