Re: [Qemu-devel] [PATCH] rewrite QEMU_BUILD_BUG_ON

[Dong Xu Wang]

QEMU_BUILD_BUG_ON is only used in ./block/qcow2-snapshot.c, so CCed Kevin.

On Tue, Dec 20, 2011 at 21:41, Stefan Hajnoczi <address@hidden> wrote:
>
> On Tue, Dec 20, 2011 at 1:12 PM, Dong Xu Wang
> <address@hidden> wrote:
> > It can compile on my Ubuntu:
> >
> > DISTRIB_ID=Ubuntu
> > DISTRIB_RELEASE=11.10
> > DISTRIB_CODENAME=oneiric
> > DISTRIB_DESCRIPTION="Ubuntu 11.10"
> >
> > gcc (Ubuntu/Linaro 4.6.1-9ubuntu3) 4.6.1
> >
> > While "gcc -E", it gets the same output as RHEL's, but it can compile. I do
> > not know why was that.  :(
>
> I see what you mean.  I find some gccs compile it successfully and
> others warn about the typedef redefinition.  Whether or not you get an
> error without the fix depends on whether your compiling warns about
> redefined typedefs.
>
> Your fix makes sense in any case.
>
> Stefan
>