|
From: | Igor Mammedov |
Subject: | Re: [Qemu-devel] [PATCH qemu-kvm] Fix: SCI isn't sent on cpu hotplug |
Date: | Mon, 09 Jan 2012 12:07:48 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 |
On 01/09/2012 11:19 AM, Jan Kiszka wrote:
On 2012-01-09 11:07, Gleb Natapov wrote:On Mon, Jan 09, 2012 at 11:03:10AM +0100, Jan Kiszka wrote:On 2012-01-09 09:47, Gleb Natapov wrote:On Sun, Jan 08, 2012 at 10:40:04PM +0100, Igor Mammedov wrote:Change introduced by e71f08bb4a "Fix cpu/pci hotplug to generate level triggered interrupt." was lost somewhre along the way. And as result SCI is not sent in case of cpu hotplug event. Restoring hunk 1 of e71f08bb4a fixes issue.Hmm, I sent similar patch [1] last time someone complained about cpu hotplug here. Which remind me that in that thread more problem were found in cpu hotplug. IIRC Jan collected all the patches. Jan, what happened to them?My patches should have been superseded by the work of Ping Fan on the ICC bus.Didn't they fix some problems with bringing new cpu online, not just making cpu hotplugable in qdev? May be I misremember.Let me check... Hmm, yes, there were also some bits required to bring up the new VCPU thread properly and sync its initial state to the kernel.
CPU bring-up seems to be broken now, guest sees a new cpu but I can't online it inside guest with error: "CPUx: Not responding". But it works with old qemu-kvm [3925c857a574]. Jan could you point me to this patches?
That was not part of Ping Fan's ICC patches, also not of the VCPU life cycle patches.
I'm trying to re-base cpu-hotplug to qemu.git, and with ICC patches it's working like the current qemu-kvm head. But without above mentioned fixes it seams to be useless.
BTW do you know what happened with ICC bus patches?Were forgotten to merge? And/or they lacked some acked-by or reviewed-by. :-/ Jan
-- Thanks, Igor
[Prev in Thread] | Current Thread | [Next in Thread] |