Re: [Qemu-devel] [PATCH 10/11] test: eliminate libcheck tests and have make check use gtester

[Andreas Färber]

Am 09.01.2012 16:56, schrieb Anthony Liguori:
> Signed-off-by: Anthony Liguori <address@hidden>
> ---
>  configure      |   33 +--------------------------------
>  tests/Makefile |   11 ++++++-----
>  2 files changed, 7 insertions(+), 37 deletions(-)

> diff --git a/tests/Makefile b/tests/Makefile
> index cff9ff3..cba482f 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -1,3 +1,7 @@
> +CHECKS=check-qdict check-qfloat check-qint check-qstring check-qlist
> +CHECKS+=check-qjson test-coroutine test-qmp-output-visitor
> +CHECKS+=test-qmp-input-visitor

I think we're using
VAR = value1 value2
VAR += value3 value4
elsewhere (e.g., Makefile.objs), which resembles our Coding Style.

Might it make sense to put coroutine on its own line (so that one can
comment it out) and semantically group the QMP visitors into one line
instead?

Otherwise very nice. Looking forward to using gtester with qtest.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg