[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool.py |
Date: |
Wed, 11 Jan 2012 10:07:23 +0000 |
On Tue, Jan 10, 2012 at 10:59 AM, Harsh Prateek Bora
<address@hidden> wrote:
> +# Generator that yields Event objects given a trace-events file object
> +def read_events(fobj):
> + event_num = 0
> + for line in fobj:
> + if not line.strip():
> + continue
> + if line.lstrip().startswith('#'):
> + continue
> + yield Event(event_num, line)
> + event_num += 1
Please use 4 space indentation. There is also a use of tab on the
converters['simple']['c'] = simple_c line earlier on.
Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool.py, Stefan Hajnoczi, 2012/01/11
Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool.py,
Stefan Hajnoczi <=