[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/10] fdc: DIR (Digital Input Register) should
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 10/10] fdc: DIR (Digital Input Register) should return status of current drive... |
Date: |
Wed, 11 Jan 2012 21:48:23 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111220 Thunderbird/9.0 |
Am 08.01.2012 21:27, schrieb Hervé Poussineau:
>
> Signed-off-by: Hervé Poussineau <address@hidden>
> ---
> hw/fdc.c | 9 ++-------
> 1 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/hw/fdc.c b/hw/fdc.c
> index 7af0f7e..a23fb1e 100644
> --- a/hw/fdc.c
> +++ b/hw/fdc.c
> @@ -932,13 +933,7 @@ static uint32_t fdctrl_read_dir(FDCtrl *fdctrl)
> {
> uint32_t retval = 0;
>
> - if (fdctrl_media_changed(drv0(fdctrl))
> - || fdctrl_media_changed(drv1(fdctrl))
> -#if MAX_FD == 4
> - || fdctrl_media_changed(drv2(fdctrl))
> - || fdctrl_media_changed(drv3(fdctrl))
> -#endif
> - )
> + if (fdctrl_media_changed(get_cur_drv(fdctrl)))
> retval |= FD_DIR_DSKCHG;
Braces :) (Most famous review comment...)
Andreas
> if (retval != 0) {
> FLOPPY_DPRINTF("Floppy digital input register: 0x%02x\n", retval);
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 04/10] fdc: emulate stepping 0, (continued)
- [Qemu-devel] [PATCH 04/10] fdc: emulate stepping 0, Hervé Poussineau, 2012/01/08
- [Qemu-devel] [PATCH 01/10] fdc: take head count into account, Hervé Poussineau, 2012/01/08
- [Qemu-devel] [PATCH 05/10] fdc: handle read-only floppies (abort early on write commands), Hervé Poussineau, 2012/01/08
- [Qemu-devel] [PATCH 06/10] block: add a transfer rate for floppy types, Hervé Poussineau, 2012/01/08
- [Qemu-devel] [PATCH 07/10] fdc: check if media rate is correct before doing any transfer, Hervé Poussineau, 2012/01/08
- [Qemu-devel] [PATCH 08/10] fdc: add CCR (Configuration Control Register) write register, Hervé Poussineau, 2012/01/08
- [Qemu-devel] [PATCH 10/10] fdc: DIR (Digital Input Register) should return status of current drive..., Hervé Poussineau, 2012/01/08
- Re: [Qemu-devel] [PATCH 10/10] fdc: DIR (Digital Input Register) should return status of current drive...,
Andreas Färber <=
- [Qemu-devel] [PATCH 09/10] fdc: fix seek command, which shouldn't check tracks, Hervé Poussineau, 2012/01/08