qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 11/15] block: add bdrv_find_backing_image


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v4 11/15] block: add bdrv_find_backing_image
Date: Thu, 12 Jan 2012 13:01:35 +0000

On Thu, Jan 12, 2012 at 12:17 PM, Kevin Wolf <address@hidden> wrote:
> Am 06.01.2012 15:01, schrieb Stefan Hajnoczi:
>> +BlockDriverState *bdrv_find_backing_image(BlockDriverState *bs, const char 
>> *id)
>> +{
>> +    if (!bs->drv) {
>> +        return NULL;
>> +    }
>> +
>> +    if (bs->backing_hd) {
>> +        if (strcmp(bs->backing_file, id) == 0) {
>> +            return bs->backing_hd;
>
> So it's not really just some id, but the backing file name? I would find
> it clearer to reflect that in the parameter name and the QMP error in
> the next patch.

Okay, thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]