Re: [Qemu-devel] [PATCH 03/30] ppc: remove ppc440 bamboo board support

[Alexander Graf]

On 13.01.2012, at 15:24, Andreas Färber wrote:

> Am 13.01.2012 13:30, schrieb Alexander Graf:
>> 
>> On 13.01.2012, at 12:45, Paolo Bonzini wrote:
>> 
>>> On 01/13/2012 12:04 PM, Andreas Färber wrote:
>>>>>>>> This board never worked with TCG.  It hasn't been updated since 
>>>>>>>> 0.13.0.  I'm
>>>>>>>> fairly sure hardware doesn't exist anymore that you can run the KVM 
>>>>>>>> support
>>>>>>>> with.
>>>>>> 
>>>>>> It does exist, I have one:-)
>>>> Alex has already posted series to not only qdev'ify it but to also add
>>>> TCG support so other people can test it. Review and testing would
>>>> probably be appreciated.:)
>>> 
>>> The work that you guys are putting in modernizing the PPC boards is really 
>>> cool.  Please, let's start working on the 1.1 changelog now so that it 
>>> doesn't get lost!
>> 
>> Good point :). I'm not sure how useful something like "Qdev'ified board xxx" 
>> really is in a changelog though. It's mostly invisible to users.
> 
> This is inviting a flame war on whether users read Change Logs and
> whether a Change Log needs to be useful to them. ;)

Users read changelogs. Packagers read changelogs. QEMU Developers read mailing 
lists. Libvirt developers might read changelogs. Qdev is a QEMU developer 
visible feature, so it doesn't belong into the changelog. Unless you want to 
argue that it makes stuff available through -device at which point it's 
management tool visible. Oh well. I probably just don't want to bloat it too 
much :).

> I concur with Paolo that TCG support for Bamboo is worth mentioning
> (user-visible feature) and so would a new, real PReP machine if we
> manage in time.

Yes, both definitely should show up!

> The conversions could be summarized under a QOM heading.
> But since neither has been applied to master yet, we should wait with
> the Change Log update. But thanks for the reminder, good idea!

If it's been posted on the ML, nobody complained on it and it's in the 
maintainer's queue, it's fine to update the changelog imho :).


Alex

> 
> Andreas
> 
> http://wiki.qemu.org/ChangeLog/1.1
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg