qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 02/10] fdc: set busy bit when starting a comm


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v2 02/10] fdc: set busy bit when starting a command
Date: Mon, 16 Jan 2012 10:33:49 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0

Am 15.01.2012 08:51, schrieb Hervé Poussineau:
> This bit must be active while a command is currently executed.
> 
> Signed-off-by: Hervé Poussineau <address@hidden>

I believe this could use some more cleanup. The flag is set and reset
multiple times in places that aren't quite obvious. Not saying it should
be done in this patch, but maybe in a follow-up series.

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]