[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/14] lm32: Fix mixup of uint32 and uint32_t
From: |
Michael Walle |
Subject: |
Re: [Qemu-devel] [PATCH 01/14] lm32: Fix mixup of uint32 and uint32_t |
Date: |
Mon, 16 Jan 2012 22:39:38 +0100 |
User-agent: |
KMail/1.13.5 (Linux/2.6.32-5-686-bigmem; KDE/4.4.5; i686; ; ) |
Am Montag 16 Januar 2012, 12:27:01 schrieb Peter Maydell:
> On 16 January 2012 00:46, Andreas Färber <address@hidden> wrote:
> > diff --git a/hw/milkymist-vgafb_template.h
> > b/hw/milkymist-vgafb_template.h index 69af9ef..544b55e 100644
> > --- a/hw/milkymist-vgafb_template.h
> > +++ b/hw/milkymist-vgafb_template.h
> > @@ -39,7 +39,7 @@
> > #elif BITS == 24
> > #define COPY_PIXEL(to, r, g, b) \
> > do { \
> > - uint32 tmp = rgb_to_pixel24(r, g, b); \
> > + uint32_t tmp = rgb_to_pixel24(r, g, b); \
> > *(to++) = tmp & 0xff; \
> > *(to++) = (tmp >> 8) & 0xff; \
> > *(to++) = (tmp >> 16) & 0xff; \
>
> This change breaks the otherwise consistent alignment of the '\'
> characters in column 51...
apart from that,
Acked-by: Michael Walle <address@hidden>
--
michael