qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] rtc: initialize irq even if caller doesn't use


From: Hervé Poussineau
Subject: Re: [Qemu-devel] [PATCH] rtc: initialize irq even if caller doesn't use rtc_init() function
Date: Mon, 23 Jan 2012 13:00:43 +0100
User-agent: Thunderbird 2.0.0.23 (Windows/20090812)

Jan Kiszka a écrit :
On 2012-01-23 10:18, Hervé Poussineau wrote:
rtc instanciated with -device has now a working irq line

That makes no sense. The mc146818rtc is no_user - for a reason.

What is the use case you are trying to address?


I wanted to be able to instanciate it with isa_create_simple(isa_bus, "mc146818rtc") in machine init code.
I don't see any good reason why a rtc created this way can't work.

The commit message can be changed to:
"rtc: initialize irq even if caller doesn't use rtc_init() function
rtc instancianted with isa_create_simple() has now a working irq line"
if you prefer...

Hervé




reply via email to

[Prev in Thread] Current Thread [Next in Thread]