[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore |
Date: |
Wed, 25 Jan 2012 11:55:36 +0000 |
User-agent: |
Alpine 2.00 (DEB 1167 2008-08-23) |
On Wed, 25 Jan 2012, Avi Kivity wrote:
> On 01/19/2012 04:16 PM, Stefano Stabellini wrote:
> > >
> > > If you are migrating to a newer qemu then the <original-addr> could in
> > > principal change, I think.
> >
> > Not unless the implementation of qemu_ram_alloc_from_ptr or
> > find_ram_offset change, but these are core qemu functions.
>
> Both of these functions will be removed. There will no longer be a
> qemu-internal address space for physical memory; instead memory will be
> addressed using a (MemoryRegion, offset) pair.
>
> We can/will hook memory_region_init_ram() to call xen_ram_alloc() which
> can then generate those old addresses, but those (like qemu_ram_alloc())
> are dependent on allocation order and you shouldn't depend on them
> returning stable values.
>
> > Or the device starts allocating more memory of course, but it wouldn't
> > be the same device anymore.
> > In any case, if we also match on the MemoryRegion name we cannot go
> > wrong.
>
> Match on just the MemoryRegion (and match on the object itself, not the
> name; see xen_register_framebuffer()).
I agree that would be ideal, but how can that work across save/restore?
Unless we introduce some other kind of identifier for MemoryRegion, the
best we have is the name right now, correct?
- [Qemu-devel] [PATCH v3 0/6] save/restore on Xen, Stefano Stabellini, 2012/01/19
- [Qemu-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore, Stefano Stabellini, 2012/01/19
- Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore, Ian Campbell, 2012/01/19
- Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore, Stefano Stabellini, 2012/01/19
- Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore, Ian Campbell, 2012/01/19
- Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore, Stefano Stabellini, 2012/01/19
- Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore, Avi Kivity, 2012/01/25
- Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore,
Stefano Stabellini <=
- Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore, Avi Kivity, 2012/01/25
[Qemu-devel] [PATCH v3 1/6] vl.c: do not save the RAM state when Xen is enabled, Stefano Stabellini, 2012/01/19
[Qemu-devel] [PATCH v3 2/6] xen mapcache: check if memory region has moved., Stefano Stabellini, 2012/01/19
[Qemu-devel] [PATCH v3 6/6] xen: change memory access behavior during migration., Stefano Stabellini, 2012/01/19
[Qemu-devel] [PATCH v3 3/6] Set runstate to INMIGRATE earlier, Stefano Stabellini, 2012/01/19
[Qemu-devel] [PATCH v3 4/6] cirrus_vga: do not reset videoram on resume, Stefano Stabellini, 2012/01/19