[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 6/9] hw/vexpress.c: Factor out daughterboard-
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v2 6/9] hw/vexpress.c: Factor out daughterboard-specific initialization |
Date: |
Wed, 25 Jan 2012 19:04:31 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111220 Thunderbird/9.0 |
Am 24.01.2012 13:39, schrieb Peter Maydell:
> Factor out daughterboard specifics into a data structure and
> daughterboard initialization function, in preparation for adding
> vexpress-a15 support.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> hw/vexpress.c | 118
> ++++++++++++++++++++++++++++++++++++++++-----------------
> 1 files changed, 83 insertions(+), 35 deletions(-)
>
> diff --git a/hw/vexpress.c b/hw/vexpress.c
> index 99a9690..9033b50 100644
> --- a/hw/vexpress.c
> +++ b/hw/vexpress.c
> +struct VEDBoardInfo {
> + const target_phys_addr_t *motherboard_map;
> + const target_phys_addr_t loader_start;
const for a value type in a struct looks fishy...is it intentional and
valid C99?
Otherwise looks okay.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH v2 9/9] hw/vexpress.c: Add vexpress-a15 machine, (continued)
- [Qemu-devel] [PATCH v2 4/9] hw/vexpress.c: Make motherboard peripheral memory map table-driven, Peter Maydell, 2012/01/24
- [Qemu-devel] [PATCH v2 5/9] hw/vexpress.c: Move secondary CPU boot code to SRAM, Peter Maydell, 2012/01/24
- [Qemu-devel] [PATCH v2 2/9] Add Cortex-A15 CPU definition, Peter Maydell, 2012/01/24
- [Qemu-devel] [PATCH v2 1/9] Add dummy implementation of generic timer cp15 registers, Peter Maydell, 2012/01/24
- [Qemu-devel] [PATCH v2 6/9] hw/vexpress.c: Factor out daughterboard-specific initialization, Peter Maydell, 2012/01/24
- Re: [Qemu-devel] [PATCH v2 6/9] hw/vexpress.c: Factor out daughterboard-specific initialization,
Andreas Färber <=
- [Qemu-devel] [PATCH v2 8/9] arm_boot: Pass base address of GIC CPU interface, not whole GIC, Peter Maydell, 2012/01/24