Re: [Qemu-devel] [PATCH 2/6] qdev-property: Make bit property parsing stricter

[Andreas Färber]

Am 27.01.2012 08:27, schrieb Stefan Hajnoczi:
> From: Jan Kiszka <address@hidden>
> 
> By using strncasecmp, we allow for arbitrary characters after the
> "on"/"off" string. Fix this by switching to strcasecmp.
> 
> Reviewed-by: Andreas Färber <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
> Signed-off-by: Jan Kiszka <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>

FWIW the ordering is wrong here. The tags are supposed to document the
patch flow: The patch was first signed off by the author (Jan), then
reviewed, then signed off by committers. Not first reviewed.

No need to respin but please keep in mind for the future.
(Yeah, did that wrong myself before.)

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg