[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 4/9] exec: add missing breaks to the watch_mem_wri
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [RFC 4/9] exec: add missing breaks to the watch_mem_write |
Date: |
Sun, 29 Jan 2012 10:49:34 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111220 Thunderbird/9.0 |
Am 29.01.2012 03:19, schrieb Max Filippov:
> Signed-off-by: Max Filippov <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Good catch!
Andreas
> ---
> exec.c | 12 +++++++++---
> 1 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index 5b9eb9a..0e93e0e 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -3279,9 +3279,15 @@ static void watch_mem_write(void *opaque,
> target_phys_addr_t addr,
> {
> check_watchpoint(addr & ~TARGET_PAGE_MASK, ~(size - 1), BP_MEM_WRITE);
> switch (size) {
> - case 1: stb_phys(addr, val);
> - case 2: stw_phys(addr, val);
> - case 4: stl_phys(addr, val);
> + case 1:
> + stb_phys(addr, val);
> + break;
> + case 2:
> + stw_phys(addr, val);
> + break;
> + case 4:
> + stl_phys(addr, val);
> + break;
> default: abort();
> }
> }
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [RFC 0/9] target-xtensa: implement debug option, Max Filippov, 2012/01/28
- [Qemu-devel] [RFC 1/9] target-xtensa: add DEBUGCAUSE SR and configuration, Max Filippov, 2012/01/28
- [Qemu-devel] [RFC 2/9] target-xtensa: implement instruction breakpoints, Max Filippov, 2012/01/28
- [Qemu-devel] [RFC 3/9] target-xtensa: add ICOUNT SR and debug exception, Max Filippov, 2012/01/28
- [Qemu-devel] [RFC 5/9] exec: fix check_watchpoint exiting cpu_loop, Max Filippov, 2012/01/28
- [Qemu-devel] [RFC 6/9] exec: let cpu_watchpoint_insert accept larger watchpoints, Max Filippov, 2012/01/28
- [Qemu-devel] [RFC 4/9] exec: add missing breaks to the watch_mem_write, Max Filippov, 2012/01/28
- Re: [Qemu-devel] [RFC 4/9] exec: add missing breaks to the watch_mem_write,
Andreas Färber <=
- [Qemu-devel] [RFC 8/9] target-xtensa: add DEBUG_SECTION to overlay tool, Max Filippov, 2012/01/28
- [Qemu-devel] [RFC 7/9] target-xtensa: add DBREAK data breakpoints, Max Filippov, 2012/01/28
- [Qemu-devel] [RFC 9/9] target-xtensa: add breakpoint tests, Max Filippov, 2012/01/28