[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Why QEMUClock is defined in qemu-timer.c?
From: |
Richard Yang |
Subject: |
Re: [Qemu-devel] Why QEMUClock is defined in qemu-timer.c? |
Date: |
Tue, 31 Jan 2012 14:35:01 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Jan 31, 2012 at 01:12:24PM +0700, Mulyadi Santosa wrote:
>Hi :)
>
>On Tue, Jan 31, 2012 at 12:55, Richard Yang <address@hidden> wrote:
>>
>> Hi, experts
>>
>> I am just coming to the qemu world.
>>
>> While reading the code, I am wondering why put a struct definition in the
>> c file?
>>
>> Seems there is no error in compile, while I felt it is not a proper way
>> to do it.
>
>
>maybe someone just forgot to refactor it :) I suggest to send a patch
>to do just that and let's see what everybody thinks about. I, myself
>thinks that the more readable the code is, the better
Ok, let me do it.
>
>--
>regards,
>
>Mulyadi Santosa
>Freelance Linux trainer and consultant
>
>blog: the-hydra.blogspot.com
>training: mulyaditraining.blogspot.com
--
Richard Yang
Help you, Help me