qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 14/15] i440fx: move bios loading to i440fx


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 14/15] i440fx: move bios loading to i440fx
Date: Tue, 31 Jan 2012 08:57:59 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15

On 01/31/2012 08:53 AM, Jan Kiszka wrote:
On 2012-01-31 15:50, Anthony Liguori wrote:
On 01/31/2012 08:38 AM, Jan Kiszka wrote:
On 2012-01-26 20:00, Anthony Liguori wrote:
---
   hw/pc.c       |   70 ++++--------------------------------------------------
   hw/pc.h       |    3 +-
   hw/piix_pci.c |   74 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-
   sysemu.h      |    2 -
   4 files changed, 79 insertions(+), 70 deletions(-)

How does the ISA PC get its BIOS after this change? Or did that change
in a step I miss right now?

Oh, I broke it.  I made no attempt to keep ISA PC working.

The way I'd like to handle this is to introduce a ROM device so that this code
would be trivialized.

Or just keep the common pc.c library as I voted for. It has its purpose,
obviously.

Coding sharing needs to happen through device sharing. Otherwise we'll be stuck in the magic device creation through arbitrary functions rut that we currently find ourselves in.

Regards,

Anthony Liguori


Jan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]