qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set w


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers
Date: Thu, 02 Feb 2012 14:58:34 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15

On 02/02/2012 01:21 PM, Andreas Färber wrote:
Am 02.02.2012 20:06, schrieb Anthony Liguori:
On 02/02/2012 10:45 AM, Paolo Bonzini wrote:
Move the creation of QmpInputVisitor and QmpOutputVisitor from
qmp.c to qom/object.c, since it's the only practical way to access
object properties.

Signed-off-by: Paolo Bonzini<address@hidden>
---
   include/qemu/object.h |   24 ++++++++++++++++++++++++
   qmp.c                 |   17 ++---------------
   qom/object.c          |   29 +++++++++++++++++++++++++++++
   3 files changed, 55 insertions(+), 15 deletions(-)

I don't want object.h to have a dependency on QObject.  We need to phase
out QObject.

We did get that dependency though by your move of the property code to
object.c. As you will see shortly, we now need qobject-obj-y and
qapi-obj-y plus some stubs to make the user emulators compile with QOM.


That's an implementation detail of Error, that's not because QObject is used anywhere in QOM.

Regards,

Anthony Liguori

Andreas





reply via email to

[Prev in Thread] Current Thread [Next in Thread]