Re: [Qemu-devel] [PATCH] hw/vmmouse.c: Disable vmmouse after reboot

[Gerhard Wiesinger]

On Fri, 3 Feb 2012, Anthony Liguori wrote:

> On 01/25/2012 02:04 PM, Gerhard Wiesinger wrote:
> > Bugfix after reboot when vmmouse was enabled and another OS which uses e.g. 
> > PS/2
> > mouse.
> >
> > Details:
> > When a guest activated the vmmouse followed by a reboot the vmmouse was 
> > still
> > enabled and the PS/2 mouse was therefore unsusable. When another guest is 
> > then
> > booted without vmmouse support (e.g. PS/2 mouse) the mouse is not working.
> >
> > Reason is that VMMouse has priority and disables all other mouse entities
> > and therefore must be disabled on reset.
> >
> > Testscenario:
> > 1.) Boot e.g. OS with VMMouse support (e.g. Windows with VMMouse tools)
> > 2.) reboot
> > 3.) Boot e.g. OS without VMMouse support (e.g. DOS) => PS/2 mouse doesn't 
> > work
> > any more. Fixes that issue.
> >
> > Testscenario 2 by Jan Kiszka <address@hidden>:
> > Confirm that this patch fixes a real issue. Setup: qemu.git,
> > opensuse 11.4 guest, SDL graphic, system_reset while guest is using the
> > vmmouse. Without the patch, the vmmouse become unusable after the
> > reboot. Also, the mouse stays in absolute mode even before X starts again.
> >
> > Fixed by:
> > Disabling the vmmouse in its reset handler.
> >
> > Signed-off-by: Gerhard Wiesinger <address@hidden>
>
> Applied.  Thanks.
>
> Regards,
>
> Anthony Liguori

Thanks.

BTW: Why are always "signed offs" generated when a maintainer commits?
e.g. 069ab0eb8a46bc4ff6f4d4d81bf037d3441347da
Signed-off-by: Anthony Liguori <address@hidden>

Ciao,
Gerhard

--
http://www.wiesinger.com/