qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address pro


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer
Date: Sat, 04 Feb 2012 01:43:38 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0

On 02/04/2012 01:21 AM, Paolo Bonzini wrote:
I'm not sure... we would trade removal of an ugly concept (the legacy
properties) with addition of a layering violation (poking into the
DeviceState subclasses).

The main problem here is that you said no to a hierarchy of property classes. This is what would be good here: being able to say "does this property have legacy print/parse methods?" and call them if available from device_add.

So, you can choose your poison. :) For now I think the idea in this patch series is good enough for its purpose (which is to actually _use_ QOM), we can tweak the design and really eliminate the legacy properties later. I don't mind going through multiple iterations as long as the state after each iteration is clearly better than before.
f
Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]