[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ARM devboards: Set arm_sysctl properties before
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH] ARM devboards: Set arm_sysctl properties before init, not after |
Date: |
Thu, 9 Feb 2012 13:18:03 +0000 |
User-agent: |
KMail/1.13.7 (Linux/3.1.0-1-amd64; KDE/4.6.5; x86_64; ; ) |
> Am 09.02.2012 13:15, schrieb Paul Brook:
> >> The ARM devboard models (vexpress-a9, realview, versatilepb, etc)
> >> were accidentally trying to set one of the arm_sysctl properties
> >> after device init. This has now become a fatal error; set the property
> >> before device init where it should be done instead.
> >>
> >> Signed-off-by: Peter Maydell <address@hidden>
> >> ---
> >> If somebody would like to commit this simple patch quickly that would
> >> probably be a good idea since these models are otherwise totally
> >> broken...
> >
> > Done.
>
> Your commit should've contained Paolo's Reviewed-by tag after Peter's
> SoB,
Ok.
> and you as committer didn't sign it off either.
Ah, I thought SoB was only relevant if I'd actually touched the patch.
Paul