[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] AHCI: Fix port reset race
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] AHCI: Fix port reset race |
Date: |
Thu, 09 Feb 2012 15:42:28 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 |
Am 30.01.2012 23:29, schrieb Alexander Graf:
> bdrv_aio_cancel() can trigger bdrv_aio_flush() which makes all aio
> that is currently in flight finish. So what we do is:
>
> port reset
> detect ncq in flight
> cancel ncq
> delete ncq sg list
>
> at which point we have double freed the sg list. Instead, with this
> patch we do:
>
> port reset
> detect ncq in flight
> cancel ncq
> check if we are really still in flight
> delete ncq sg list
>
> which makes things work and gets rid of the race.
>
> Signed-off-by: Alexander Graf <address@hidden>
Thanks, applied to the block branch.
Kevin
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] AHCI: Fix port reset race,
Kevin Wolf <=