qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 06/19] gdbstub: Error locations for -gdb


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 06/19] gdbstub: Error locations for -gdb
Date: Thu, 09 Feb 2012 16:08:16 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)

Kevin Wolf <address@hidden> writes:

> Am 07.02.2012 15:09, schrieb Markus Armbruster:
>> Stash away the option argument with add_device_config(), so we still
>> have its location when we get around to parsing it.
>> 
>> This doesn't improve any messages I can see just yet, but that'll
>> change shortly.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> gdb isn't really a device, though. Should the struct and the functions
> be renamed?

The current names don't bother me, but I'd be fine with a rename, too.
Unless I need to respin anyway, I'd rather leave it to a follow-up
patch, though.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]