[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 03/11] trace: [tracetool] Simplify event line
From: |
Harsh Bora |
Subject: |
Re: [Qemu-devel] [PATCH v3 03/11] trace: [tracetool] Simplify event line parsing |
Date: |
Fri, 10 Feb 2012 17:23:51 +0530 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Thunderbird/3.0.5 |
On 02/10/2012 05:19 PM, Lluís Vilanova wrote:
Signed-off-by: Lluís Vilanova<address@hidden>
---
scripts/tracetool.py | 51 +++++++++++++++++++-------------------------------
1 files changed, 19 insertions(+), 32 deletions(-)
diff --git a/scripts/tracetool.py b/scripts/tracetool.py
index 7042728..549a90e 100755
--- a/scripts/tracetool.py
+++ b/scripts/tracetool.py
[...]
# A trace event
+import re
+cre = re.compile("(?P<name>[^(\s]+)\((?P<args>[^)]*)\)\s*(?P<fmt>\".*)?")
+
class Event(object):
def __init__(self, num, line):
self.num = num
- self.args = get_args(line)
+ m = cre.match(line)
+ assert m is not None
+ groups = m.groupdict('')
+ self.args = groups["args"]
self.arglist = self.args.split(',')
- self.name = get_name(line)
- self.argc = get_argc(line)
- self.argnames = get_argnames(line)
- self.sizestr = calc_sizeofargs(line)
- self.fmt = get_fmt(line)
+ self.name = groups["name"]
+ if len(self.arglist) == 1 and self.arglist[0] == "void":
+ self.argc = 0
+ else:
+ self.argc = len(self.arglist)
+ if self.name == "slavio_misc_update_irq_raise":
+ sys.stderr.write("%s : %d" % (self.name, self.argc))
I guess above 2 statements were added for debugging ^ ?
Harsh
+ self.argnames = get_argnames(self.args)
+ self.sizestr = calc_sizeofargs(self.args, self.argc)
+ self.fmt = groups["fmt"]
# Generator that yields Event objects given a trace-events file object
def read_events(fobj):
- [Qemu-devel] [PATCH v3 00/11] tracetool: Improvements for future expansion, Lluís Vilanova, 2012/02/10
- [Qemu-devel] [PATCH v3 01/11] [trivial] Fix a compiler warning, Lluís Vilanova, 2012/02/10
- [Qemu-devel] [PATCH v3 02/11] trace: [tracetool] Do not rebuild event list in backend code, Lluís Vilanova, 2012/02/10
- [Qemu-devel] [PATCH v3 03/11] trace: [tracetool] Simplify event line parsing, Lluís Vilanova, 2012/02/10
- Re: [Qemu-devel] [PATCH v3 03/11] trace: [tracetool] Simplify event line parsing,
Harsh Bora <=
- [Qemu-devel] [PATCH v3 04/11] trace: [ŧrac etool] Do not precompute the event number, Lluís Vilanova, 2012/02/10
- [Qemu-devel] [PATCH v3 05/11] trace: [tracetool] Add support for event properties, Lluís Vilanova, 2012/02/10
- [Qemu-devel] [PATCH v3 06/11] trace: [tracetool] Process the "disable" event property, Lluís Vilanova, 2012/02/10
- [Qemu-devel] [PATCH v3 07/11] trace: [tracetool] Rewrite event argument parsing, Lluís Vilanova, 2012/02/10
- [Qemu-devel] [PATCH v3 10/11] trace: Provide a per-event status define for conditional compilation, Lluís Vilanova, 2012/02/10
- [Qemu-devel] [PATCH v3 09/11] trace: [tracetool] Automatically establish available backends and formats, Lluís Vilanova, 2012/02/10
- [Qemu-devel] [PATCH v3 11/11] trace: [tracetool] Add error-reporting functions, Lluís Vilanova, 2012/02/10
- [Qemu-devel] [PATCH v3 08/11] trace: [tracetool] Make format-specific code optional and with access to event information, Lluís Vilanova, 2012/02/10