Re: [Qemu-devel] [RFC Patch 5/7]Qemu: raw-posix image file reopen

[Supriya Kannery]

On 02/02/2012 05:45 AM, Michael Roth wrote:
> On 01/31/2012 09:07 PM, Supriya Kannery wrote:
> > raw-posix driver changes for bdrv_reopen_xx functions to
> > safely reopen image files. Reopening of image files while
> > changing hostcache dynamically is handled here.

> > +
> > + /* Flags that can be set using fcntl */
> > + int fcntl_flags = BDRV_O_NOCACHE;
> > +
> > + if ((bs->open_flags& ~fcntl_flags) == (flags& ~fcntl_flags)) {
> > + if ((flags& BDRV_O_NOCACHE)) {
> > + s->open_flags |= O_DIRECT;
> > + } else {
> > + s->open_flags&= ~O_DIRECT;
> > + }
> > + printf("O_DIRECT flag\n");
> > + ret = fcntl_setfl(s->fd, s->open_flags);
>
> raw-posix.c:raw_aio_submit() does some extra alignment work if
> s->aligned_buf was set due to the image being opened O_DIRECT initially,
> not sure what the impact is but probably want to clean that up here.

ok, will check on this

thanks! for reviewing
Supriya