[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migr
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode |
Date: |
Tue, 14 Feb 2012 10:24:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.26) Gecko/20120130 Red Hat/3.1.18-1.el6_2 Thunderbird/3.1.18 |
Hi,
> I can do it, by retrieving the surfaces addresses from the tracked guest
> commands.
Exactly.
> However, if we already do it, it would be even better if we
> just dirty only the areas that are actually modified by the update_area
> calls. The problem is that (1) spice-server updates surfaces also
> without request from driver.
On worker->stop() for example, which renderes all outstanding commands
so all state is flushed to the surfaces (and thereby device memory).
This is done on vm_stop too, so I wouldn't be surprised if most surfaces
are dirtied anyway at this point. Getting notifications about
spice-server touching surfaces doesn't buy us much then.
cheers,
Gerd