[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] i386: Remove REGPARM
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] i386: Remove REGPARM |
|
Date: |
Wed, 15 Feb 2012 11:36:16 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 |
On 02/15/2012 10:11 AM, Blue Swirl wrote:
> #if defined(CONFIG_SOFTMMU)
> - int mem_index, s_bits, arg_idx;
> + int mem_index, s_bits;
> +#if TCG_TARGET_REG_BITS == 64
> + int arg_idx;
> +#else
> + int stack_adjust;
> +#endif
...
> - if (TCG_TARGET_REG_BITS == 64) {
> - tcg_out_mov(s, (opc == 3 ? TCG_TYPE_I64 : TCG_TYPE_I32),
...
> +#if TCG_TARGET_REG_BITS == 32
> + tcg_out_pushi(s, mem_index);
Any particular reason you didn't continue with the C-if form,
so that you could avoid the extra ifdeffery at the top there?
r~