[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] qdev: print error message before aborting
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] qdev: print error message before aborting |
Date: |
Fri, 17 Feb 2012 16:30:57 +0000 |
On 14 February 2012 09:19, Paolo Bonzini <address@hidden> wrote:
> qdev_prop_set_* functions are always called by machine init functions
> that should know what they're doing, so they abort on error. Still,
> an assert(!errp) does not aid debugging. Print an error before aborting.
So now you get:
qemu-system-arm: Insufficient permission to perform this operation
Aborted
This still isn't really very diagnostic: I had to run the whole
thing under a debugger and look at the backtrace anyway before
I realised I'd hit the same problem again. Isn't there some way
to supply a more specific message than this? (some string that
actuall mentions at least one of "object", "property" and
"after initialization", for example :-))
-- PMM