[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 08/12] exec: fix check_watchpoint exiting cpu_loop
From: |
Max Filippov |
Subject: |
[Qemu-devel] [PATCH 08/12] exec: fix check_watchpoint exiting cpu_loop |
Date: |
Sat, 18 Feb 2012 21:11:39 +0400 |
In case of BP_STOP_BEFORE_ACCESS watchpoint check_watchpoint intends to
signal EXCP_DEBUG exception on exit from cpu loop, but later overwrites
exception code by the cpu_resume_from_signal call.
Use cpu_loop_exit with BP_STOP_BEFORE_ACCESS watchpoints.
Signed-off-by: Max Filippov <address@hidden>
---
exec.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/exec.c b/exec.c
index f105b43..ed091f3 100644
--- a/exec.c
+++ b/exec.c
@@ -3257,11 +3257,12 @@ static void check_watchpoint(int offset, int len_mask,
int flags)
tb_phys_invalidate(tb, -1);
if (wp->flags & BP_STOP_BEFORE_ACCESS) {
env->exception_index = EXCP_DEBUG;
+ cpu_loop_exit(env);
} else {
cpu_get_tb_cpu_state(env, &pc, &cs_base, &cpu_flags);
tb_gen_code(env, pc, cs_base, cpu_flags, 1);
+ cpu_resume_from_signal(env, NULL);
}
- cpu_resume_from_signal(env, NULL);
}
} else {
wp->flags &= ~BP_WATCHPOINT_HIT;
--
1.7.7.6
- [Qemu-devel] [PATCH 01/12] target-xtensa: define TLB_TEMPLATE for MMU-less cores, (continued)
- [Qemu-devel] [PATCH 01/12] target-xtensa: define TLB_TEMPLATE for MMU-less cores, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 03/12] target-xtensa: fetch 3rd opcode byte only when needed, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 02/12] target-xtensa: implement info tlb monitor command, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 04/12] target-xtensa: add DEBUGCAUSE SR and configuration, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 05/12] target-xtensa: implement instruction breakpoints, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 06/12] target-xtensa: add ICOUNT SR and debug exception, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 07/12] exec: add missing breaks to the watch_mem_write, Max Filippov, 2012/02/18
- Re: [Qemu-devel] [PATCH 07/12] exec: add missing breaks to the watch_mem_write, Meador Inge, 2012/02/20
- [Qemu-devel] [PATCH 08/12] exec: fix check_watchpoint exiting cpu_loop,
Max Filippov <=
- [Qemu-devel] [PATCH 09/12] exec: let cpu_watchpoint_insert accept larger watchpoints, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 11/12] target-xtensa: add DEBUG_SECTION to overlay tool, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 10/12] target-xtensa: add DBREAK data breakpoints, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 12/12] target-xtensa: add breakpoint tests, Max Filippov, 2012/02/18
- Re: [Qemu-devel] [PULL 00/12] target-xtensa queue, Max Filippov, 2012/02/26