[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] boards: qemu_register_machine(): return voi
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] boards: qemu_register_machine(): return void |
Date: |
Fri, 24 Feb 2012 15:17:47 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120208 Thunderbird/10.0.1 |
Am 24.02.2012 15:13, schrieb Luiz Capitulino:
> It never fails.
...and is never checked. Low-impact cleanup, thanks.
>
> Signed-off-by: Luiz Capitulino <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Andreas
> ---
> hw/boards.h | 2 +-
> vl.c | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/boards.h b/hw/boards.h
> index 667177d..7a9899f 100644
> --- a/hw/boards.h
> +++ b/hw/boards.h
> @@ -31,7 +31,7 @@ typedef struct QEMUMachine {
> struct QEMUMachine *next;
> } QEMUMachine;
>
> -int qemu_register_machine(QEMUMachine *m);
> +void qemu_register_machine(QEMUMachine *m);
> QEMUMachine *find_default_machine(void);
>
> extern QEMUMachine *current_machine;
> diff --git a/vl.c b/vl.c
> index 7a8cc08..45fc3b5 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1163,7 +1163,7 @@ void pcmcia_info(Monitor *mon)
> static QEMUMachine *first_machine = NULL;
> QEMUMachine *current_machine = NULL;
>
> -int qemu_register_machine(QEMUMachine *m)
> +void qemu_register_machine(QEMUMachine *m)
> {
> QEMUMachine **pm;
> pm = &first_machine;
> @@ -1171,7 +1171,6 @@ int qemu_register_machine(QEMUMachine *m)
> pm = &(*pm)->next;
> m->next = NULL;
> *pm = m;
> - return 0;
> }
>
> static QEMUMachine *find_machine(const char *name)
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
[Qemu-devel] [PATCH 4/5] boards: switch machine type list to QTAILQ, Luiz Capitulino, 2012/02/24