Re: [Qemu-devel] [PATCH 5/5] boards: move all machine type functions to boards.c

[Luiz Capitulino]

On Fri, 24 Feb 2012 16:10:17 +0100
Andreas Färber <address@hidden> wrote:

> Am 24.02.2012 15:13, schrieb Luiz Capitulino:
> > The license text is the same as used in vl.c. Also note that it's
> > necessary to make machine_parse() public.
> > 
> > Signed-off-by: Luiz Capitulino <address@hidden>
> > ---
> >  Makefile.target |    3 +-
> >  hw/boards.c     |   86 
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  hw/boards.h     |    1 +
> >  vl.c            |   65 -----------------------------------------
> >  4 files changed, 89 insertions(+), 66 deletions(-)
> >  create mode 100644 hw/boards.c
> 
> In anticipation of a "board" class derived from "container" I would
> rather have the file name match the class name, i.e. board.c.
> Unfortunately boards.h is used in quite a lot of places already, but
> when we QOM'ify it we might want to move it to include/qemu so all users
> would need to be touched anyway.

I don't min doing the rename work, but Anthony is talking about having a Machine
type. So, maybe it's a better idea to do rename along with the QOM conversion,
as that's when we'll be sure about the class name.

> > diff --git a/Makefile.target b/Makefile.target
> > index d5eb70d..dc76eba 100644
> > --- a/Makefile.target
> > +++ b/Makefile.target
> > @@ -195,7 +195,8 @@ endif #CONFIG_BSD_USER
> >  # System emulator target
> >  ifdef CONFIG_SOFTMMU
> >  
> > -obj-y = arch_init.o cpus.o monitor.o machine.o gdbstub.o balloon.o ioport.o
> > +obj-y = arch_init.o cpus.o monitor.o machine.o gdbstub.o balloon.o 
> > ioport.o \
> > +           boards.o
> 
> Please use obj-y += ... instead of the line break.

Ok.

> 
> Otherwise looks okay.
> 
> Andreas
>