qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-mig


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands
Date: Fri, 24 Feb 2012 22:05:29 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1

On 02/24/2012 09:36 PM, Luiz Capitulino wrote:
> > > IMO, you could require the filename arguments to be escaped already.
> > 
> > The monitor command was introduced exactly to avoid having to worry
> > about details such as escaping.  JSON is already supposed to take care
> > of those.
> 
> Then the escaping should be done by the parser, not by the command
> implementation.

This command is passing its arguments to the block layer, which needs
its own escaping.  It's a wart of the block layer and not supposed to
percolate outside QEMU.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]