[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ds1338: Add missing break statement
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] ds1338: Add missing break statement |
Date: |
Sat, 25 Feb 2012 16:06:45 +0000 |
On 25 February 2012 13:50, Stefan Weil <address@hidden> wrote:
> Without the break statement, case 5 sets month and year from the same
> data. This does not look correct.
Yep, looks like a simple missing break, checked against the
datasheet at http://datasheets.maxim-ic.com/en/ds/DS1338-DS1338Z.pdf
Reviewed-by: Peter Maydell <address@hidden>