[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/8] Add universal DMA helper functions
From: |
Eduard - Gabriel Munteanu |
Subject: |
Re: [Qemu-devel] [PATCH 4/8] Add universal DMA helper functions |
Date: |
Mon, 27 Feb 2012 13:55:20 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Feb 27, 2012 at 12:33:49PM +0200, Michael S. Tsirkin wrote:
> On Mon, Feb 27, 2012 at 11:22:43AM +1100, David Gibson wrote:
> > On Sun, Feb 26, 2012 at 12:04:49PM +0200, Michael S. Tsirkin wrote:
> > > On Fri, Feb 24, 2012 at 02:27:39PM +1100, David Gibson wrote:
[snip]
> > >
> > > I'm a bit confused with all the stubbing going on.
> > > Is this the final form of the pci_* functions or just
> > > a stub? If the final form, we probably should just
> > > open-code them - they don't buy us much.
> > > If not, let's add a comment?
> >
> > Well.. it's the intended final form of pci_dma_*() - which do become
> > trivial wrappers, yes.
>
> I'd say let's drop them then (in a follow-up patch). The topic is
> confusing enough without having to wade through layers of wrappers :)
>
Drop them how? Using dma_* stuff directly? That might work, but I
remember others suggesting we should use a specialized PCI wrapper.
Perhaps it makes sense if some other bus, or PCI itself at some point,
needs to do something special.
> > It's _not_ the intended final form of dma_*(),
> > which need to grow code to do actual IOMMU translation. I'll add a
> > comment about this in the next round.
> >
> > --
> > David Gibson | I'll have my music baroque, and my
> > code
> > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_
> > _other_
> > | _way_ _around_!
> > http://www.ozlabs.org/~dgibson
[Qemu-devel] [PATCH 8/8] Make dma_addr_t 64 bit always, David Gibson, 2012/02/23
[Qemu-devel] [PATCH 5/8] usb-ohci: Use universal DMA helper functions, David Gibson, 2012/02/23
[Qemu-devel] [PATCH 6/8] Make sglists and dma_bdrv helpers use new universal DMA herlpers, David Gibson, 2012/02/23
[Qemu-devel] [PATCH 3/8] usb-xhci: Use PCI DMA helper functions, David Gibson, 2012/02/23