Re: [Qemu-devel] [PATCH] VMXNET3 paravirtual NIC device implementation

[Andreas Färber]

Hello,

Am 28.02.2012 20:57, schrieb Izik Eidus:
> On Tue, Feb 28, 2012 at 2:50 PM, Yan Vugenfirer <address@hidden> wrote:
>> On Tue, Feb 28, 2012 at 6:43 PM, malc <address@hidden> wrote:
>>> On Tue, 28 Feb 2012, Yan Vugenfirer wrote:
>>>> @@ -0,0 +1,146 @@
>>>> +/*
>>>> + * QEMU VMWARE paravirtual devices - auxiliary code
>>>> + *
>>>> + * Copyright (c) 2012 Ravello Systems LTD (http://ravellosystems.com)
>>>> + * All Rights Reserved
>>>
>>> Not quite sure, i'm follwing this, here it says that all rights are
>>> reserved.
> 
> isn`t this is the common GPL2 licence format?
> for example from the very same qemu:
> /*
>  * qemu/kvm integration
>  *
>  * Copyright (C) 2006-2008 Qumranet Technologies
>  *
>  * Licensed under the terms of the GNU GPL version 2 or higher.
>  */
> 
> Do we miss anything? because our meaning is to publish it as a fully
> GPL2 licensed code...
> 
>>>> + *
>>>> + * Developed by Daynix Computing LTD (http://www.daynix.com)
>>>> + *
>>>> + * Authors:
>>>> + * Dmitry Fleytman <address@hidden>
>>>> + * Yan Vugenfirer <address@hidden>
>>>> + *
>>>> + * This program is free software; you can redistribute it and/or modify it
>>>> + * under the terms of the GNU General Public License as published by the
>>>> + * Free Software Foundation; version 2 of the License and no later 
>>>> version.

This is not the common GPLv2 license format: You say "and no later"
rather than "or (at your option) any later version". Is there any
particular reason for this, or was that just an oversight?
Please compare http://wiki.qemu.org/Relicensing on our efforts to make
code GPLv2+.

>>>> + *
>>>> + * This program is distributed in the hope that it will be useful, but
>>>> + * WITHOUT ANY WARRANTY; without even the implied warranty of
>>>> + * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
>>>> + * NON INFRINGEMENT.  See the GNU General Public License for more
>>>> + * details.
>>>> + *
>>>> + * You should have received a copy of the GNU General Public License
>>>> + * along with this program; if not, write to the Free Software
>>>> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 
>>>> USA.

To avoid dealing with the constantly changing FSF postal address, please
use a link to their licenses page or to the specific (versioned) license
as outlined on gnu.org.

>>>> + *
>>>> + * The full GNU General Public License is included in this distribution in
>>>> + * the file called "COPYING".
>>>> + *
>>>> + */

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg