[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] rename blockdev-group-snapshot-sync
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] rename blockdev-group-snapshot-sync |
Date: |
Wed, 29 Feb 2012 12:08:42 -0300 |
On Wed, 29 Feb 2012 15:25:29 +0100
Paolo Bonzini <address@hidden> wrote:
> Il 29/02/2012 14:37, Paolo Bonzini ha scritto:
> > + assert(!(dev_info->snapshot->has_format && format));
>
> Oops, this wanted to be
>
> assert(dev_info->snapshot->has_format == (format != NULL));
>
> but it can just be omitted, I wasn't sure of how QAPI handled optionals.
Do you now?
All optionals will be accompanied of a 'bool has_OPTIONAL_NAME', this bool
will be true if the optional has been passed by the caller/client or false
otherwise (in which case you shouldn't trust it).
- [Qemu-devel] [PATCH 0/6] Mirrored writes using blockdev-transaction, Paolo Bonzini, 2012/02/29
- [Qemu-devel] [PATCH 1/6] fix format name for backing file, Paolo Bonzini, 2012/02/29
- [Qemu-devel] [PATCH 2/6] qapi: complete implementation of unions, Paolo Bonzini, 2012/02/29
- [Qemu-devel] [PATCH 5/6] Add blkmirror block driver, Paolo Bonzini, 2012/02/29
- [Qemu-devel] [PATCH 3/6] rename blockdev-group-snapshot-sync, Paolo Bonzini, 2012/02/29
- Re: [Qemu-devel] [PATCH 3/6] rename blockdev-group-snapshot-sync, Eric Blake, 2012/02/29
- [Qemu-devel] [PATCH 6/6] add mirroring to blockdev-transaction, Paolo Bonzini, 2012/02/29
- [Qemu-devel] [PATCH 4/6] add reuse field, Paolo Bonzini, 2012/02/29