[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH v5 12/14] monitor: remove unused do_info_trace
From: |
Harsh Prateek Bora |
Subject: |
[Qemu-devel] [RFC PATCH v5 12/14] monitor: remove unused do_info_trace |
Date: |
Thu, 1 Mar 2012 18:55:38 +0530 |
Going forward with simpletrace v2 variable size trace records, we cannot
have a generic function to print trace event info and therefore this
interface becomes invalid.
As per Stefan Hajnoczi:
"This command is only available from the human monitor. It's not very
useful because it historically hasn't been able to pretty-print events
or show them in the right order (we use a ringbuffer but it prints
them out from index 0).
Therefore, I don't think we're under any obligation to keep this
command around. No one has complained about it's limitations - I
think this is a sign that no one has used it. I'd be okay with a
patch that removes it."
Ref: http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg01268.html
Signed-off-by: Harsh Prateek Bora <address@hidden>
---
monitor.c | 16 ----------------
1 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/monitor.c b/monitor.c
index ffda0fe..365ce47 100644
--- a/monitor.c
+++ b/monitor.c
@@ -942,13 +942,6 @@ static void do_info_cpu_stats(Monitor *mon)
}
#endif
-#if defined(CONFIG_TRACE_SIMPLE)
-static void do_info_trace(Monitor *mon)
-{
- st_print_trace((FILE *)mon, &monitor_fprintf);
-}
-#endif
-
static void do_trace_print_events(Monitor *mon)
{
trace_print_events((FILE *)mon, &monitor_fprintf);
@@ -3033,15 +3026,6 @@ static const mon_cmd_t info_cmds[] = {
.help = "show roms",
.mhandler.info = do_info_roms,
},
-#if defined(CONFIG_TRACE_SIMPLE)
- {
- .name = "trace",
- .args_type = "",
- .params = "",
- .help = "show current contents of trace buffer",
- .mhandler.info = do_info_trace,
- },
-#endif
{
.name = "trace-events",
.args_type = "",
--
1.7.1.1
- [Qemu-devel] [RFC PATCH v5 00/14] Tracing Improvements, Simpletrace v2, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 06/14] trace: [tracetool] Process the "disable" event property, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 12/14] monitor: remove unused do_info_trace,
Harsh Prateek Bora <=
- [Qemu-devel] [RFC PATCH v5 14/14] scripts/simpltrace.py changes: Support simplettrace v2, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 05/14] trace: [tracetool] Add support for event properties, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 07/14] trace: [tracetool] Rewrite event argument parsing, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 11/14] trace: [tracetool] Add error-reporting functions, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 02/14] trace: [tracetool] Do not rebuild event list in backend code, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 08/14] trace: [tracetool] Make format-specific code optional with access to events, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 03/14] trace: [tracetool] Simplify event line parsing, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 13/14] Simpletrace v2: Handle var num of args, strings., Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 09/14] trace: [tracetool] Automatically establish available backends and formats, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 04/14] trace: [tracetool] Do not precompute the event number, Harsh Prateek Bora, 2012/03/01