[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async
Date: Mon, 05 Mar 2012 12:16:23 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15

On 03/05/2012 11:29 AM, Avi Kivity wrote:
On 03/05/2012 07:27 PM, Anthony Liguori wrote:
On 03/05/2012 11:20 AM, Avi Kivity wrote:
On 03/05/2012 04:33 PM, Anthony Liguori wrote:

async in QEMU doesn't mean "generate a QMP event when you're done".
It should mean execute this closure when you finish (function pointer
+ opaque).

The QMP event should be dispatched from the closure such that the
screendump code doesn't have to have a direct dependency on QMP.

What about using the parallel execution facility of qmp?  It's silly to
duplicate every command X with X-async and X-COMPLETED.

We need to switch over to QAPI to get there.

Just an implementation detail, yes?  No spec/protocol changes?


   We're pretty close to being there.  Luiz, about how long do you
think before we get there?

It's a pity to add new commands along the way.

It's more complicated than this unfortunately.

A client needs to be able to determine whether the 'screendump' command works as expected. Unfortunately, when QXL was introduced, 'screendump' became broken across multiple releases.

screendump is the right interface, but since it was broken in multiple releases, we need another command for a client to determine that it's not broken. In the short term, screendump_async is that. After QAPI, it will probably be a screendump2.

I don't mind introducing short term commands and then deprecating it particularly when they are marked as such.


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]