[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions |
|
Date: |
Mon, 05 Mar 2012 22:16:40 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
Il 05/03/2012 20:44, Paolo Bonzini ha scritto:
> Il 05/03/2012 19:55, Eric Blake ha scritto:
>> Right now, libvirt has an API virDomainSnapshotCreateXML with a flag
>> VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT, which should map to this new mode
>> operand. Am I guaranteed that if I pass a 'mode' argument of 'existing'
>> to an older qemu that lacked mode, I will get a sane error? If so, then
>> this rewrite looks fine from libvirt's point of view.
>
> Not sure... Luiz?
Well, you could always use the transaction command if the flag is there.
That command will have it always.
Paolo
[Qemu-devel] [PATCH v3 3/8] rename blockdev-group-snapshot-sync, Paolo Bonzini, 2012/03/05
[Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions, Paolo Bonzini, 2012/03/05
[Qemu-devel] [PATCH v3 1/8] fix format name for backing file, Paolo Bonzini, 2012/03/05
[Qemu-devel] [PATCH v3 6/8] Add blkmirror block driver, Paolo Bonzini, 2012/03/05
[Qemu-devel] [PATCH v3 7/8] add mirroring to transaction, Paolo Bonzini, 2012/03/05
[Qemu-devel] [PATCH v3 4/8] add mode field to blockdev-snapshot-sync transaction item, Paolo Bonzini, 2012/03/05
[Qemu-devel] [PATCH v3 8/8] add drive-mirror command and HMP equivalent, Paolo Bonzini, 2012/03/05
[Qemu-devel] [PATCH v3 9/8] Add the drive-reopen command, Paolo Bonzini, 2012/03/06
[Qemu-devel] [PATCH v3 10/8] use QSIMPLEQ_FOREACH_SAFE when freeing list elements, Paolo Bonzini, 2012/03/06