[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7 |
Date: |
Tue, 6 Mar 2012 15:31:51 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Mar 02, 2012 at 04:49:44PM +0100, Hans de Goede wrote:
Ack. Anthony, this breaks build for libcacard, caused by my last commit
to the same file as Brad noted:
commit 0082f4336e128a17d5f34e01de0fd29930e99b0d
Author: Alon Levy <address@hidden>
Date: Sun Feb 26 17:09:24 2012 +0100
libcacard: fix reported ATR length
Can you apply?
Thanks,
Alon
> VCARD_ATR_PREFIX is used as part of an array initializer so it should
> not have () around it, so far this happened to work, but gcc-4.7 does
> not like it.
>
> Signed-off-by: Hans de Goede <address@hidden>
> ---
> libcacard/vcardt.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libcacard/vcardt.h b/libcacard/vcardt.h
> index d4d8e2e..d3e9522 100644
> --- a/libcacard/vcardt.h
> +++ b/libcacard/vcardt.h
> @@ -26,8 +26,8 @@ typedef struct VCardEmulStruct VCardEmul;
> #define MAX_CHANNEL 4
>
> /* create an ATR with appropriate historical bytes */
> -#define VCARD_ATR_PREFIX(size) (0x3b, 0x68+(size), 0x00, 0xff, \
> - 'V', 'C', 'A', 'R', 'D', '_')
> +#define VCARD_ATR_PREFIX(size) 0x3b, 0x68+(size), 0x00, 0xff, \
> + 'V', 'C', 'A', 'R', 'D', '_'
>
>
> typedef enum {
> --
> 1.7.7.6
>
>