[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files.
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files. |
Date: |
Thu, 08 Mar 2012 22:29:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120215 Thunderbird/10.0.2 |
Am 08.03.2012 10:16, schrieb Gerd Hoffmann:
> Plan is basically to move all usb stuff to hw/usb/
>
> Comments?
hw/usb/ is fine with me (hw/ide/ is precedence), but I strongly dislike
the dev-*.c convention you've used:
For one thing, we'd have to rename 90+% of hw/ to be consistent.
For another, dev-foo.c is not natural English for a certain type of
device - foo-dev.c would be better but I'd prefer without "dev", i.e.,
hw/usb/{audio,ccid,...}.c. And then of course only devices should go
into hw/.
Also, Anthony was recently talking about building up a new Linux-like
directory structure inside qom/ but I don't see that working yet and
renames are cheap in git anyway, so I guess that's no reason against
hw/usb/ as an interim improvement.
Anthony further said he had a patch to avoid having to create
subdirectories in configure for the out-of-tree builds. That would
simplify both this and my *-user QOM series. Any update on that?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
[Qemu-devel] [RfC PATCH 2/2] usb: zap hw/ush-{ohic, uhci}.h + init wrappers, Gerd Hoffmann, 2012/03/08
Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files.,
Andreas Färber <=
Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files., Anthony Liguori, 2012/03/08