[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] block: Virtual Bridges VERDE GOW disk image
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] block: Virtual Bridges VERDE GOW disk image format, legacy GOW version 1 support implementation |
Date: |
Fri, 09 Mar 2012 13:04:48 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 |
Am 08.03.2012 23:15, schrieb Leonardo E. Reiter:
> +BlockDriver bdrv_gow1 = {
> + .format_name = "gow1",
> + .instance_size = sizeof(gow1_state_t),
> + .bdrv_probe = gow1_probe,
> + .bdrv_file_open = gow1_open,
> + .bdrv_close = gow1_close,
> + .bdrv_read = gow1_read,
> + .bdrv_write = gow1_write,
> +
> + .bdrv_create = gow1_create,
> + .bdrv_getlength = gow1_getlength,
> + .bdrv_truncate = gow1_truncate,
> + .create_options = gow1_create_options,
> +};
I wonder whether a name like verde_gow[123] wouldn't make more sense. I
think most people wouldn't be able to associate something with "gow",
and it doesn't look like a good keyword for searches either.
Also, is gow1 so different that implementing it in the same driver with
gow[23] would be impossible?
Kevin