[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter i
From: |
Mark Langsdorf |
Subject: |
Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys |
Date: |
Fri, 09 Mar 2012 08:52:43 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 |
On 03/09/2012 08:17 AM, Markus Armbruster wrote:
> Mark Langsdorf <address@hidden> writes:
>
>> On 03/09/2012 03:25 AM, Markus Armbruster wrote:
>>> get_image_size() returns int. How does widening size and max_sz here
>>> improve things?
>>
>> If max_sz is greater than 2GB, then:
>> int max_sz = 0xc0000000;
>> int size = 0x300;
>> if (size > max_sz)
>> return -1;
>>
>> returns -1, even though size is much less than max_sz.
>>
>> doing it my way:
>> unsigned long max_sz = 0xc0000000;
>> unsigned long size = 0x300;
>> if (size > max_sz)
>> return -1;
>>
>> does not return -1.
>
> The current code limits max_sz to INT_MAX. Passing 0xc0000000 is a bug.
>
> You want to relax the limit. That's fair. But I'm afraid your patch
> doesn't really relax the limit, or rather it relaxes it just by one bit.
>
> Your example shows it works for a case where the higher limit isn't
> needed. Let's examine three cases where it is: image sizes 2GiB, 4GiB
> and 5GiB on a host with 32 bit twos complement int, and 64 bit unsigned
> size_t, max_sz 0xc0000000.
I'm quite willing to leave the problem of people loading 2GiB images to
another day. Loading a 300KiB on an ARM machine with 4GiB of memory is
a problem I'm facing right now, though.
> I'm afraid you need to do more work to solve this problem. If you're
> willing to do that, please check out
> http://lists.nongnu.org/archive/html/qemu-devel/2012-02/msg03627.html
I'm inclined to agree with David that this is not the issue I'm trying
to solve =)
--Mark Langsdorf
Calxeda, Inc.
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, (continued)
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, Peter Maydell, 2012/03/10
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, Andreas Färber, 2012/03/10
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, Peter Maydell, 2012/03/10
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, Mark Langsdorf, 2012/03/12
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, Markus Armbruster, 2012/03/12
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, Alexander Graf, 2012/03/12
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, Peter Maydell, 2012/03/12
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, Andreas Färber, 2012/03/12
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, Andreas Färber, 2012/03/12
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, Markus Armbruster, 2012/03/09
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys,
Mark Langsdorf <=
- Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys, Markus Armbruster, 2012/03/09
[Qemu-devel] [PATCH v2] use an unsigned long for the max_sz parameter in load_image_targphys, Mark Langsdorf, 2012/03/09
[Qemu-devel] [PATCH] arm highbank: force ramsize to INT_MAX when loading, Mark Langsdorf, 2012/03/09
[Qemu-devel] [PATCH v3] use an uint64_t for the max_sz parameter in load_image_targphys, Mark Langsdorf, 2012/03/12