[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to d
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors |
Date: |
Fri, 09 Mar 2012 19:59:44 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-03-09 19:31, Anthony Liguori wrote:
> On 03/09/2012 12:20 PM, Jan Kiszka wrote:
>> On 2012-03-09 19:13, Luiz Capitulino wrote:
>>> The Monitor object is passed back and forth within the migration/savevm
>>> code so that it can print errors and progress to the user.
>>>
>>> However, that approach assumes a HMP monitor, being completely invalid
>>> in QMP.
>>>
>>> This commit drops almost every single usage of the Monitor object, all
>>> monitor_printf() calls have been converted into DPRINTF() ones.
>>
>> I guess for most printfs, this is OK. But do you provide an alternative
>> for the block migration progress output? I did not find anything on
>> first glance. That is not a debugging feature.
>
> The block migration progress stuff is horribly broken and I regret ever
> merging
> it. Are you actively relying on this?
>
> Does block migration even work?
The last time I tried (a while back), it worked for me, but I also
received reports that it was not working reliably.
>
> Could we just remove block migration entirely...
Well, if we have a better alternative, replace it.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, (continued)
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Luiz Capitulino, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Jan Kiszka, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Anthony Liguori, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Luiz Capitulino, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Luiz Capitulino, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Anthony Liguori, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Eric Blake, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Anthony Liguori, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Eric Blake, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Eric Blake, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors,
Jan Kiszka <=
[Qemu-devel] [PATCH 4/4] qapi: Convert migrate, Luiz Capitulino, 2012/03/09
Re: [Qemu-devel] [PATCH 4/4] qapi: Convert migrate, Alon Levy, 2012/03/09