Re: [Qemu-devel] [PATCH v1 1/1] ppc: Correctly define POWERPC_INSNS2_DEFAULT

[Alexander Graf]

On 05.03.2012, at 21:26, Meador Inge wrote:

> On 03/05/2012 01:53 PM, Andreas Färber wrote:
> 
>> Am 05.03.2012 18:06, schrieb Meador Inge:
>>> On 02/23/2012 07:44 AM, Meador Inge wrote:
>>> 
>>>> 'POWERPC_INSNS2_DEFAULT' was defined incorrectly which was causing the
>>>> opcode table creation code to erroneously register 'eieio' and 'mbar'
>>>> for the "default" processor:
>>>> 
>>>>   ** ERROR: opcode 1a already assigned in opcode table 16
>>>>   *** ERROR: unable to insert opcode [1f-16-1a]
>>>>   *** ERROR initializing PowerPC instruction 0x1f 0x16 0x1a
>>>> 
>>>> Signed-off-by: Meador Inge <address@hidden>
>>> 
>>> Ping.
>> 
>> Cc'ing qemu-ppc.
>> 
>> What's the test case (command line) that breaks? Don't all machines use
>> different default CPUs? I would rather drop these ..._DEFAULT defines in
>> favor of using a real CPU model - but maybe I'm misunderstanding something?
> 
> I meant quite literally the "default" CPU:
> 
> $ ./install/bin/qemu-system-ppc -cpu default
> *** ERROR: opcode 1a already assigned in opcode table 16
> *** ERROR: unable to insert opcode [1f-16-1a]
> *** ERROR initializing PowerPC instruction 0x1f 0x16 0x1a
> Segmentation fault (core dumped)

Ouch. And thanks, applied to ppc-next.


Alex